Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boojum): Fix VK in prover_fri_protocol_versions #174

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(boojum): Fix VK in prover_fri_protocol_versions #174

merged 1 commit into from
Oct 9, 2023

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Oct 9, 2023

What ❔

Use SNARK wrapper VK instead of FRI scheduler VK in proof_data_handler

Why ❔

It will be saved to prover_fri_protocol_versions, and we need them consistent with protocol_versions.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@ly0va ly0va requested review from perekopskiy and mm-zk October 9, 2023 08:09
@ly0va ly0va requested a review from a team as a code owner October 9, 2023 08:09
@ly0va ly0va changed the title Fix VK in prover_fri_protocol_versions fix(boojum): Fix VK in prover_fri_protocol_versions Oct 9, 2023
@ly0va ly0va force-pushed the lyova-fix-vks-in-fri-prover-protocol-versions branch from 068590b to d7ccbb4 Compare October 9, 2023 08:12
@ly0va ly0va merged commit 742ec84 into boojum-integration Oct 9, 2023
18 of 21 checks passed
Oppen referenced this pull request in lambdaclass/zksync-era Feb 9, 2024
@AntonD3
Update scheduler_key.json, regenerate verifier (#174)
cc8fe35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@mm-zk mm-zk Awaiting requested review from mm-zk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ly0va @perekopskiy